Add plugin: AudioPen Sync

[jonashaefele]

I am submitting a new Community Plugin

Repo URL

Link to my plugin:
https://github.com/jonashaefele/audiopen-obsidian/

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word Obsidian in your plugin name since it's redundant and adds clutter to the plugin list.

---

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin name mismatch, the name in this PR (AudioPen Sync) is not the same as the one in your repo (AudioPen-Obsidian Sync). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.

---

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.

[1][2][3]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

---

Optional

[1]:Casting to any should be avoided as much as possible.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[jonashaefele]

Updated the repo with a new release, fixing all required issues.

I can't fix the optional issue, because type definitions of this.app aren't correct.

Without casting this.app as any, I get TS error:

Property 'setting' does not exist on type 'App'.

This has been documented here: https://forum.obsidian.md/t/open-settings-for-my-plugin-community-plugin-settings-deeplink/61563/3

Edit: I changed it to @ts-ignore the lines where this.app.setting and this.app.plugin are used. That should make the bot happy. Type definitions on those two properties would make this redundant.

[ObsidianReviewBot]

Changes requested by bot have been made, assigning human for additional review.

[joethei]

Copyright (c) 2021 Stephen Solka
Update this.

"description": "Plugin and service that syncs new AudioPen notes to Obsidian.",
Avoid including sentences like "This is a plugin for Obsidian that does ..." in your description, it should be self-evident that this is a plugin for Obsidian.
We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.

syncStatus = 'Fully Synced', item.setTitle('Force Sync').setIcon('sync').onClick(this.forceBufferSync), item.setTitle('Open Buffer').onClick(() => {, .setButtonText('Reset Settings')
Use sentence case in UI

containerEl.createEl('h2', { text: 'AudioPen Sync' })
Don't include a header with the plugin name in the settings

containerEl.createEl('h2', { text: 'Advanced settings' })
Avoid "settings" in settings headings

containerEl.createEl('h2', { text: 'Advanced settings' }), containerEl.createEl('h2', { text: 'Danger zone' }), containerEl.createEl('h2', { text: 'Support' })
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

kofiImg.src = 'https://storage.ko-fi.com/cdn/kofi3.png?v=3'
This should be bundled, not loaded externally.

[jonashaefele]

Thanks for the super quick and thorough review @joethei

And here was me thinking I got the sentence case right everywhere. My bad.
I learned a lot from this little PR. Guess I was very confused because a lot of the plugins I use don't follow the guidelines, so I made my plugin "look like the ones I use". But it does look way nicer now that I followed the guidelines properly.

And thanks for the note on setting headings. Same here, looks way nicer.

I think all should be well now. Let me know if any other changes are needed.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: aygjiay/obsidian-link-to-verse. If you are submitting from a GitHub org, you need to be a public member of the org.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 434469

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[jonashaefele]

I updated the PR by merging master and then moving my plugin down to the very end of the list again. I hope that helps.

Let me know if there's anything else you need from me.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token } in JSON at position 437481

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}