Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deriveJSONGADT requires toJSON and parseJSON to be in scope #21

Closed
ryantrinkle opened this issue Apr 5, 2020 · 0 comments · Fixed by #28
Closed

deriveJSONGADT requires toJSON and parseJSON to be in scope #21

ryantrinkle opened this issue Apr 5, 2020 · 0 comments · Fixed by #28

Comments

@ryantrinkle
Copy link
Member

The TH should not be looking up names from the calling module's scope. Instead, they should use the names from the TH implementation's scope. The impact is that if the user does not have Data.Aeson in scope, the TH splice fails.

Here are two examples of where it's wrong:

Those are the only two I noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant