Sync with obelisk/develop #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plt-amy
suggested changes
Jul 18, 2022
|
Build failures are my bad, I only had ghcid running with 8.8.4 |
plt-amy
reviewed
Jul 18, 2022
Comment on lines
+65
to
+67
| #if !(MIN_VERSION_base(4, 13, 0)) | ||
| import Control.Monad.Fail (MonadFail) | ||
| #endif |
There was a problem hiding this comment.
@madeline-os should I use these CPP guards to only import MonadFail when needed, should I disable the "redundant imports" warning, or should I just leave the warning there?
There was a problem hiding this comment.
Go for CPP guards, or just leave the warning in there if it already exists.
hopefully gets GH actions running again
To work around NixOS/cabal2nix#550
madeline-os
approved these changes
Jul 20, 2022
plt-amy
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync cli-extras with obelisk (develop branch) in order to refactor obelisk-cliapp