Ensure daml test is always invoked from project root #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeline-os
requested changes
Apr 29, 2024
hs/src/Daml/Cucumber.hs
Outdated
| @@ -285,7 +285,9 @@ runTestSuite opts = do | |||
| case shouldRunTests of | |||
| True -> do | |||
| writeDamlScript testFile result | |||
| (ec, damlTestStdout, damlTestStderr) <- liftIO $ readProcessWithExitCode damlPath ["test", "--files", testFile] "" | |||
| let damlProc = proc damlPath ["test", "--files", testFile] | |||
There was a problem hiding this comment.
I think it would be better to use the DAML_PROJECT environment variable
There was a problem hiding this comment.
I did some manual tests as well and it is looking good, thanks!
I built daml-cucumber and from a nix-shell in hs I tested different combinations to make sure it works
../result/bin/daml-cucumber --source $(pwd) --features $(pwd)/features.feature
../result/bin/daml-cucumber --source . --features ./features.feature
./result/bin/daml-cucumber --source test --features test/features.feature
madeline-os
approved these changes
Apr 30, 2024
|
Reran a job, weird it was trying to force LLVM for |
Otherwise it may not find dependencies like java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.