Use Haskell overlays, temporarily expose __useLegacyCompilers #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| in if pkgs.stdenv.isDarwin | ||
| then removeConfigureFlag drv' "--ghc-option=-optl=-dead_strip" | ||
| else drv'; | ||
| cleanSource = builtins.filterSource (name: _: let baseName = builtins.baseNameOf name; in !( |
There was a problem hiding this comment.
Btw, it's better to use lib.cleanSourceWith than builtins.filterSource. Does the same thing, but it composes with itself, whereas builtins.filterSource cannot.
There was a problem hiding this comment.
This can actually be important if you want to filter a source provided by a user, because the user may want to pass you a source they've already filtered.
There was a problem hiding this comment.
Good point. I think I'll do that in a follow-up PR if you don't mind? (this is just moving it around.)
For one, I need a better store for the inner overlay (haskell) accessing the outer self (pkgs) than this nasty callPackage hack!
But make sure the `ob` command itself uses the new ones always.
Ericson2314
force-pushed
the
config-default-compilers
branch
from
a1fe727
to
06f7a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.