Improve packaging support for staticWhich usage #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOST_PATH is set in Nixpkgs during cross-compilation to detect binaries available at runtime. It makes sure you get the right architecture in your cross-compiled binaries. When HOST_PATH is not set, fall back to PATH.
This does what we want
findExecutablesInDirectories was only added in 1.2.4.0.
We do not always know at build-time where we will get an executable. For instance, on Nix-less systems, the Nix store will be unavailable and we need to get it some other way. We could hardcode /usr/local/bin/ to PATH so that GHC will find it, but this introduces unnecessary impurities and requires changing hashes between builds. As a workaround, just use classic “which” functionality.
matthewbauer
changed the title
3noch
reviewed
Jun 5, 2020
| exists <- doesFileExist f' | ||
|
|
||
| -- If it does, run it, otherwise fallback to classic which. | ||
| if exists then pure f' |
There was a problem hiding this comment.
Shouldn't we also check if it's executable?
Do we really want "hello" to map to ./hello and not a hello that's on your PATH?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not always know at build-time where we will get an executable.
For instance, on Nix-less systems, the Nix store will be unavailable
and we need to get it some other way. We could hardcode
/usr/local/bin/ to PATH so that GHC will find it, but this introduces
unnecessary impurities and requires changing hashes between builds. As
a workaround, just use classic “which” functionality.