Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExecuteOnBrowser wrapper on destroy #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove ExecuteOnBrowser wrapper on destroy #181

wants to merge 1 commit into from

Commits on Oct 27, 2019

  1. Remove ExecuteOnBrowser wrapper on destroy 

    Under certain conditions, when browser source scene items are removed
in a loop, CEF UI thread may hang waiting for previous invocations of
ExecuteOnBrowser() to complete resulting in a deadlock.

Since CefBrowserHost::WasHidden() and CefBrowserHost::CloseBrowser()
are not required to be called on a certain thread, removing
ExecuteOnBrowser() altogether preserves the functionality, eliminates
the deadlock and simplifies the code.
    @zavitax
    zavitax committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    29cd94b View commit details
    Browse the repository at this point in the history