Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for TakeSourceScreenshot #384

Merged
merged 3 commits into from Oct 17, 2019

Conversation

BarryCarlyon
Copy link

@BarryCarlyon BarryCarlyon commented Oct 15, 2019

Revise the wording of TakeSourceScreenshot to note that if you specify a scene name, you get the scene.

Sorta #383

@dodgepong
Copy link
Member

This is because scenes are sources. Perhaps the wording should say something like:

@param {String} `sourceName` Source name. Note that, since scenes are also sources, you can also provide a scene name.

Or perhaps more simply:

@param {String} `sourceName` Source (or scene) name.

@BarryCarlyon
Copy link
Author

Yeah that wording is better. Will revise

@Palakis Palakis merged commit 25c369d into obsproject:4.x-current Oct 17, 2019
@BarryCarlyon BarryCarlyon deleted the TakeSourceScreenshotDocs branch October 18, 2019 00:02
@Palakis Palakis added this to the 4.7 milestone Nov 12, 2019
@Palakis Palakis changed the title Take scene screenshot Fix docs for TakeSourceScreenshot Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants