Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect bitmask in libgcf #2290

Closed
mmcgo opened this issue Jan 22, 2019 · 1 comment
Closed

incorrect bitmask in libgcf #2290

mmcgo opened this issue Jan 22, 2019 · 1 comment
Projects
Release 1.1.1
Milestone
1.1.1

Comments

@mmcgo
Copy link

mmcgo commented Jan 22, 2019

libgcf.py, line 107, masks the bottom 4 bits for the compresssion code:
compression = compress & 0b00001111 # get compression code

This should mask off only the bottom 3 bits (the 4th is allocated for something else in the near future):
compression = compress & 0b00000111 # get compression code
@mmcgo mmcgo mentioned this issue Jan 22, 2019
Closed
@megies
Copy link
Member

megies commented Jan 23, 2019

That's an easy fix..

@megies megies added this to the 1.1.1 milestone Jan 23, 2019
megies added a commit that referenced this issue Feb 14, 2019
@megies
io.gcf: fix bitmask for getting compression code
f25f3eb 
fixes #2290
@megies megies mentioned this issue Feb 14, 2019
Merged
9 tasks
megies added a commit that referenced this issue Feb 14, 2019
@megies
io.gcf: fix bitmask for getting compression code
7c3e9fe 
fixes #2290
@krischer krischer added this to In progress in Release 1.1.1 Feb 14, 2019
@krischer krischer removed this from In progress in Release 1.1.1 Feb 14, 2019
@krischer krischer added this to In progress in Release 1.1.1 Feb 14, 2019
megies added a commit that referenced this issue Feb 14, 2019
@megies
io.gcf: fix bitmask for getting compression code
5ff4ed2 
fixes #2290
@megies megies moved this from In progress to Done in Release 1.1.1 Feb 14, 2019
@megies megies closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 1.1.1
  
Done
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@megies @mmcgo