New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build docs for PRs #1357
build docs for PRs #1357
Conversation
Very good idea and definitely helpful. Regarding speeding up the tests: It might be possible to install some kind of hook or monkey patch and just record all network accesses during the doc building process and store it all in some directory. On subsequent runs that directory will be used to serve all requests and we can periodically update that repository. We could also try to add one more travis build that just builds the docs and pushes it to some repository. I'm not sure if they would like that though. |
PR docs builds coming in one by one right now and will get updated automatically when pushed to. see http://docs.obspy.org/pull-requests/ (leaving this issue open because I still have to add a cronjob that removes old, closed PRs' docs) |
Beautiful! |
Current coverage is
|
* docs build for PRs can be requested by putting "+DOCS" somewhere in the github comments * current docs buildbot server has relatively low inode quota, avoid again using up all inodes see #1357
* docs build for PRs can be requested by putting "+DOCS" somewhere in the github comments * current docs buildbot server has relatively low inode quota, avoid again using up all inodes see obspy#1357
With the new Anaconda Python setup we have on our docs buildbot it would be rather unproblematic to have multiple builds running at the same time (in separate environments). I think it might be a good idea to have a cronjob running that frequently checks for updated PRs (using github API) and builds docs for them. This might especially help to judge the docs part of PRs by external contributors that do not build the docs locally for checking (for us and for them).
(A speedup of docs build time would certainly help for this one. E.g. by making client module images static and not request data via network -- at least for known to fail modules.)
Opinions? I think I'm gonna work on this when I find some time.