Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obspy-scan: plot and print overlaps #1366

Merged
merged 9 commits into from Apr 15, 2016
Merged

obspy-scan: plot and print overlaps #1366

merged 9 commits into from Apr 15, 2016

Conversation

megies
Copy link
Member

@megies megies commented Apr 5, 2016

This adds plotting (blue bars, like the red bars for gaps) and also printing (with option "--print-gaps") of overlaps.

  • slight change in handling of endtimes: use endtime+delta for end of time segments -> cleaner handling of gaps/overlaps
  • fix compress_start_end helper function: overlaps were actually always merged, even with merge_overlaps=False
  • increase coverage by testing stdout for option --print-gaps
  • save obspy version in obspy-scan npz output

@megies megies added enhancement feature request .imaging Issues with our plotting functionalities labels Apr 5, 2016
@megies megies added this to the 1.1.0 milestone Apr 5, 2016
@codecov-io
Copy link

Current coverage is 86.28%

Merging #1366 into master will decrease coverage by -0.01% as of de188a3

@@            master   #1366   diff @@
======================================
  Files          369     369       
  Stmts        50102   50127    +25
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          43234   43250    +16
  Partial          0       0       
- Missed        6868    6877     +9

Review entire Coverage Diff as of de188a3

Powered by Codecov. Updated on successful CI builds.

makes life easier afterwards when checking for gaps/overlaps +- a user
specified margin in seconds (not having to pass in the sampling rate
again)
merge_overlaps=False)

overlaps were always merged, regardless of `merge_overlaps` setting.
now also a threshold in seconds can be set that has to be exceeded to
trigger an overlap.
(gap_at_start already implies args.start_time)
(warn if loading old npz, because of tiny change in endtime handling)
@megies
Copy link
Member Author

megies commented Apr 15, 2016

Rebased. No objections so far, gonna merge this when CI passes.

@krischer
Copy link
Member

I'll do it. I was gonna object to the ugly colors ;-) But matplotlib 2.0 will change all styles in any case so we can revamp our plots when its released.

@krischer krischer merged commit 779d400 into master Apr 15, 2016
@QuLogic QuLogic deleted the scan_overlaps branch April 16, 2016 03:41
@megies
Copy link
Member Author

megies commented Apr 16, 2016

I was gonna object to the ugly colors ;-)

Only color I added is ordinary blue.. ;-) But yeah.. getting rid of these old mpl colors will be good to see.

megies added a commit that referenced this pull request Jun 8, 2016
megies added a commit that referenced this pull request Jun 13, 2016
megies added a commit that referenced this pull request Jun 14, 2016
megies added a commit that referenced this pull request Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature request .imaging Issues with our plotting functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants