fix PPSD time restrictions in stacking, compare >=/<= instead of >/< #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThomasLecocq since this is on your request, could I ask you to double check this change, especially since the test had to be changed. Otherwise we'll have to bump this to 1.0.3. |
megies
force-pushed
the
fix_ppsd_time_restrictions
branch
2 times, most recently
from
5c7bc82
to
bccc8ca
Compare
|
Bumping to 1.0.3 because we can get 1.0.2 out then soon. |
|
Changed base branch to |
|
wooooooooooooooooooooow :-) why in the world did I let this one behind ???? Now, see, I did remember we already talked about it :-) |
|
Base branch will have to be changed either to |
megies
force-pushed
the
fix_ppsd_time_restrictions
branch
from
bccc8ca
to
b0704af
Compare
|
Rebased on current maintenance branch. Still waiting for feedback in 2022 @ThomasLecocq 😝 Gonna probably just merge this for 1.3.1 😉 |
less/greater comparison to less/equal / greater/equal when comparing to start/endtimes
megies
force-pushed
the
fix_ppsd_time_restrictions
branch
from
1fa2a7b
to
5128d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PPSD time restrictions in stacking, compare >=/<= instead of >/<.