Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor improvements #1708

Merged
merged 19 commits into from Mar 8, 2017

Conversation

Projects
None yet
3 participants
@barsch
Copy link
Member

commented Mar 8, 2017

  • now building Py2.7/64 bit and Py3.6/32bit
  • enabled rolling builds: whenever you do a new commit to the same branch OR pull request all current queued/running builds for that branch or PR are cancelled and the new one is queued.
  • enabled fast finish: if first job has failed the entire build is marked as failed and no further jobs will start
  • do not build feature branch with open Pull Requests

todo in future: add +TESTS magic to enable building the full matrix (py2.7 - py3.6, 32 and 64bit)

IMHO ready to merge see: https://ci.appveyor.com/project/obspy/obspy/build/1.0.4368-appveyor

barsch added some commits Mar 6, 2017

updated run_with_env.cmd also reducing jobs to two py2.7/64 bit and
py3.6/32bit in order to speed up development

@barsch barsch requested a review from megies Mar 8, 2017

@megies megies added this to the 1.1.0 milestone Mar 8, 2017

@megies megies added CI WIN labels Mar 8, 2017

@megies

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

Great improvement to our CI, thanks @barsch!

@megies

megies approved these changes Mar 8, 2017

@krischer

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

Yea - looks great :)

now building Py2.7/64 bit and Py3.6/32bit

Contrary to that statement it currently tests both for 64 bit. Also should we maybe enable 32 and 64 bit builds? Appveyor is usually faster then travis so I don't think it will slow down our whole CI turnaround time.

@krischer

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

For future reference: There is also this package here: https://github.com/pelson/Obvious-CI

conda-forge uses it for the appveyor builds and it would make it much easier. But as you already invested all the sweat I'd leave it as it is for now :) Also I don't think this can do the early termination and rolling builds which are really cool.

@barsch

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

ups commented out the wrong version ;)

on appveyor we have only one job per time for the whole project - there is nothing parallel - so increasing the build time from 10 min to 80 min per checkin is quite a difference ... so I choose to offer only min and max python version ...

@barsch

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

ok CI good - merging

@barsch barsch merged commit cd81615 into master Mar 8, 2017

6 of 7 checks passed

codecov/changes 6 files have unexpected coverage changes not visible in diff.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c380941...5b356d2
Details
codecov/project 87.57% (+1.54%) compared to c380941
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-testbot Docker tests succeeded
Details

@barsch barsch deleted the appveyor branch Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.