Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor improvements #1708

Merged
merged 19 commits into from Mar 8, 2017
Merged

Appveyor improvements #1708

merged 19 commits into from Mar 8, 2017

Conversation

barsch
Copy link
Member

@barsch barsch commented Mar 8, 2017

  • now building Py2.7/64 bit and Py3.6/32bit
  • enabled rolling builds: whenever you do a new commit to the same branch OR pull request all current queued/running builds for that branch or PR are cancelled and the new one is queued.
  • enabled fast finish: if first job has failed the entire build is marked as failed and no further jobs will start
  • do not build feature branch with open Pull Requests

todo in future: add +TESTS magic to enable building the full matrix (py2.7 - py3.6, 32 and 64bit)

IMHO ready to merge see: https://ci.appveyor.com/project/obspy/obspy/build/1.0.4368-appveyor

@barsch barsch requested a review from megies March 8, 2017 09:16
@megies megies added this to the 1.1.0 milestone Mar 8, 2017
@megies megies added CI issue generally related to continuous integration WIN issue exclusive to Windows labels Mar 8, 2017
@megies
Copy link
Member

megies commented Mar 8, 2017

Great improvement to our CI, thanks @barsch!

@krischer
Copy link
Member

krischer commented Mar 8, 2017

Yea - looks great :)

now building Py2.7/64 bit and Py3.6/32bit

Contrary to that statement it currently tests both for 64 bit. Also should we maybe enable 32 and 64 bit builds? Appveyor is usually faster then travis so I don't think it will slow down our whole CI turnaround time.

@krischer
Copy link
Member

krischer commented Mar 8, 2017

For future reference: There is also this package here: https://github.com/pelson/Obvious-CI

conda-forge uses it for the appveyor builds and it would make it much easier. But as you already invested all the sweat I'd leave it as it is for now :) Also I don't think this can do the early termination and rolling builds which are really cool.

@barsch
Copy link
Member Author

barsch commented Mar 8, 2017

ups commented out the wrong version ;)

on appveyor we have only one job per time for the whole project - there is nothing parallel - so increasing the build time from 10 min to 80 min per checkin is quite a difference ... so I choose to offer only min and max python version ...

@barsch
Copy link
Member Author

barsch commented Mar 8, 2017

ok CI good - merging

@barsch barsch merged commit cd81615 into master Mar 8, 2017
@barsch barsch deleted the appveyor branch March 8, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI issue generally related to continuous integration WIN issue exclusive to Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants