New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renaming obspy.io.datamark to obspy.io.win #1717
Changes from 4 commits
4a1854a
8826388
1bbee78
f35374b
67502ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,30 @@ | ||
Delivery-Date: Mon, 25 Jun 2012 09:45:50 +0200 | ||
To: barsch@egu.eu | ||
Cc: support@hakusan.co.jp | ||
Subject: Re: DataMark format description | ||
From: Akiko Hakamada <hakamada@hakusan.co.jp> | ||
Dear Sir | ||
Thank you for your inquiry. | ||
We send a part of DATAMARK LS-7000XT user's manual as a format | ||
description document. | ||
Attached file name: E-MAN_LS-7000XT_7_format.pdf | ||
Some of our products uses two kind of data format, type A0 and A1. | ||
Type A0 is also called "win format", and A1 is extended version of it. | ||
We recommend you to support type A0, because type A0 conforms to the | ||
data format of the WIN system developed by Earthquake Research Institute | ||
(ERI), the University of Tokyo, but type A1 is not recently used in most | ||
our product. | ||
Please see the web page of ERI. | ||
http://eoc.eri.u-tokyo.ac.jp/cgi-bin/show_man_en?winformat | ||
Best Regards, | ||
------------------- | ||
Akiko Hakamada | ||
Hakusan Corporation | ||
Delivery-Date: Mon, 25 Jun 2012 09:45:50 +0200 | ||
To: barsch@egu.eu | ||
Cc: support@hakusan.co.jp | ||
Subject: Re: DataMark format description | ||
From: Akiko Hakamada <hakamada@hakusan.co.jp> | ||
|
||
|
||
|
||
Dear Sir | ||
|
||
Thank you for your inquiry. | ||
|
||
We send a part of DATAMARK LS-7000XT user's manual as a format | ||
description document. | ||
Attached file name: E-MAN_LS-7000XT_7_format.pdf | ||
|
||
Some of our products uses two kind of data format, type A0 and A1. | ||
Type A0 is also called "win format", and A1 is extended version of it. | ||
We recommend you to support type A0, because type A0 conforms to the | ||
data format of the WIN system developed by Earthquake Research Institute | ||
(ERI), the University of Tokyo, but type A1 is not recently used in most | ||
our product. | ||
|
||
Please see the web page of ERI. | ||
http://eoc.eri.u-tokyo.ac.jp/cgi-bin/show_man_en?winformat | ||
|
||
Best Regards, | ||
------------------- | ||
Akiko Hakamada | ||
Hakusan Corporation |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,7 @@ | |
KEYWORDS = [ | ||
'ArcLink', 'array', 'array analysis', 'ASC', 'beachball', | ||
'beamforming', 'cross correlation', 'database', 'dataless', | ||
'Dataless SEED', 'datamark', 'earthquakes', 'Earthworm', 'EIDA', | ||
'Dataless SEED', 'win', 'earthquakes', 'Earthworm', 'EIDA', | ||
'envelope', 'ESRI', 'events', 'FDSN', 'features', 'filter', | ||
'focal mechanism', 'GCF', 'GSE1', 'GSE2', 'hob', 'Tau-P', 'imaging', | ||
'instrument correction', 'instrument simulation', 'IRIS', 'kinemetrics', | ||
|
@@ -142,7 +142,7 @@ | |
'SLIST = obspy.io.ascii.core', | ||
'PICKLE = obspy.core.stream', | ||
'CSS = obspy.io.css.core', | ||
'DATAMARK = obspy.io.datamark.core', | ||
'WIN = obspy.io.win.core', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm.. In general I agree that we can make an exception here and allow the module move/renaming without deprecation reroute, as people have no reason to use the low level routines. But.. we could still break peoples' codes if they circumvent the filetype detection, i.e. if they do Maybe we should leave the Also, maybe we should wait with merging until it's clear how this one and #1692 will play together? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would it work to state:
? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And also the other plugin lines.. yeah.. not sure about any negative side effects, but probably it should be OK like this.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or just a dummy obspy.io.datamark.core that answers it not longer exists and returns /dies. not a clean deprecation... but yah... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If you do a deprecation, than it shouldn't raise but rather show a warning and use the new location at obspy.io.win There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... and stay until 1.2 ? pfff not sure... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you do a deprecation, it will be in there for 1.1.* and removed again for 1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ThomasLecocq do you want to add a deprecation or leave as is? We plan to freeze 1.1.0 on Sunday so if this PR should be in there it should be ready by then. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd suggest to keep this as-is... I don't know many users of this routine anyway, and I've modified the docstring so that a simple googling should show DATAMARK in the io.win explanation |
||
'KINEMETRICS_EVT = obspy.io.kinemetrics.core', | ||
'GSE1 = obspy.io.gse2.core', | ||
'GSE2 = obspy.io.gse2.core', | ||
|
@@ -187,9 +187,9 @@ | |
'isFormat = obspy.io.css.core:_is_nnsa_kb_core', | ||
'readFormat = obspy.io.css.core:_read_nnsa_kb_core', | ||
], | ||
'obspy.plugin.waveform.DATAMARK': [ | ||
'isFormat = obspy.io.datamark.core:_is_datamark', | ||
'readFormat = obspy.io.datamark.core:_read_datamark', | ||
'obspy.plugin.waveform.WIN': [ | ||
'isFormat = obspy.io.win.core:_is_win', | ||
'readFormat = obspy.io.win.core:_read_win', | ||
], | ||
'obspy.plugin.waveform.KINEMETRICS_EVT': [ | ||
'isFormat = obspy.io.kinemetrics.core:is_evt', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header underline needs adjustment