Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature "Moving Window Cross-Spectrum" #1719

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ThomasLecocq
Copy link
Contributor

@ThomasLecocq ThomasLecocq commented Mar 13, 2017

What does this PR do?

Adding the Moving Window Cross-Spectral method. This method allows comparing two signals in the frequency domain (cross-spectrum, or cepstrum) and returns a table of time delays (offsets) vs time for each window.
See current doc here:
http://msnoise.org/doc/master/core.html#moving-window-cross-spectral-method

PR Checklist

This PR does look ugly because I actually branched it from #1716 , didn't really know how to do it otherwise as I need the linear_regression in this PR.

@ThomasLecocq ThomasLecocq changed the title Feature mwcs Feature "Moving Window Cross-Spectral" Mar 13, 2017
@ThomasLecocq ThomasLecocq changed the title Feature "Moving Window Cross-Spectral" Feature "Moving Window Cross-Spectrum" Mar 13, 2017
@ThomasLecocq ThomasLecocq added this to the 1.1.0 milestone Mar 13, 2017
@ThomasLecocq ThomasLecocq added the .signal issues related to our signal processing functionalities label Mar 14, 2017
@ThomasLecocq
Copy link
Contributor Author

ThomasLecocq commented Mar 14, 2017

this fails on Travis while it's OK on appveyor, it is linked to scipy' next_fast_len being available or not. In Appveyor scipy is not fixed, so it uses 0.18.1, while in Travis it seems fixed. The results of my test are different with obspy's next_pow_2 or next_fast_len ... not good.. have to find a way to check for both (and ensure the results are "similar" enough to show the method is stable).

And it's kind of scary that the linear regression is so different for different n submitted to the FFT.

@ThomasLecocq
Copy link
Contributor Author

@barsch @megies @krischer

The tests fail depending on the scipy version available, because the results of the MWCS are slightly different when using nextpow2 or next_fast_len ? Should this function be defined with nextpow2 by default but allow for some sort of callback in case one wants to use next_fast_len (scipy >= 0.18) ?

@ThomasLecocq ThomasLecocq modified the milestones: 1.2.0, 1.1.0 Mar 27, 2017
@megies megies mentioned this pull request Mar 30, 2017
6 tasks
@krischer
Copy link
Member

krischer commented Apr 6, 2017

Can you up the test tolerance to have it test similar enough on different scipy versions?

@krischer krischer added this to Free for the Taking in Release 1.2.0 Feb 14, 2019
@ThomasLecocq ThomasLecocq modified the milestones: 1.2.0, 1.3.0 Feb 14, 2019
@ThomasLecocq ThomasLecocq removed this from Free for the Taking in Release 1.2.0 Feb 14, 2019
@megies megies removed this from the 1.3.0 milestone Feb 15, 2019
@megies megies added this to the 2.0.0 milestone Feb 15, 2019
@trichter trichter modified the milestones: 1.3.0, 1.4.0 Jan 6, 2022
@megies megies modified the milestones: 1.4.0, Future release Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.signal issues related to our signal processing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants