New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature "Moving Window Cross-Spectrum" #1719
base: master
Are you sure you want to change the base?
Conversation
this fails on Travis while it's OK on appveyor, it is linked to scipy' And it's kind of scary that the linear regression is so different for different |
The tests fail depending on the scipy version available, because the results of the MWCS are slightly different when using nextpow2 or next_fast_len ? Should this function be defined with nextpow2 by default but allow for some sort of callback in case one wants to use next_fast_len (scipy >= 0.18) ? |
Can you up the test tolerance to have it test similar enough on different scipy versions? |
What does this PR do?
Adding the Moving Window Cross-Spectral method. This method allows comparing two signals in the frequency domain (cross-spectrum, or cepstrum) and returns a table of time delays (offsets) vs time for each window.
See current doc here:
http://msnoise.org/doc/master/core.html#moving-window-cross-spectral-method
PR Checklist
it is linked to Ambient Seismic Noise in ObsPy #841 and branched from generalized linear_regression #1716
All tests still pass.
Any new features or fixed regressions are be covered via new tests.
Any new or changed features have are fully documented.
Significant changes have been added to
CHANGELOG.txt
.I should provide an example with some figures.
This PR does look ugly because I actually branched it from #1716 , didn't really know how to do it otherwise as I need the linear_regression in this PR.