Raise exception when attempting to read very large mini-SEED files #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krischer
changed the title
|
appveyor is acting up. Can IMHO be ignored for this PR. |
megies
approved these changes
Apr 2, 2017
|
Is the branch name |
Looks more like it's looking in the wrong repo.. But branch is on @krischer's fork.. ?! |
|
I think its because I accidentially pushed to the obspy fork at one point because I forgot to set the remote tracking branch. Still a bug in appveyor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is already described here: #1419
It will likely be a while until we can properly fix this and multiple people ran into this issue and thus ObsPy now raises a proper exception message with instructions on how to still read these files if it encounters this problem.
Error message is:
"ObsPy can currently not directly read mini-SEED files that are larger than 2^31 bytes (2048 MiB). To still read it, please read the file in chunks as documented here: https://github.com/obspy/obspy/pull/1419#issuecomment-221582369"