Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some urllib and future.standard_library usages #2140

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@megies
Copy link
Member

megies commented May 7, 2018

What does this PR do?

  • remove remaining instances of with future.standard_library.hooks(): with either importing in a if/else depending on Python 2/3 or by using requests.compat (which is internally doing just the same as well)
  • remove some urllib usages with requests

Why was it initiated? Any relevant Issues?

Closes #1254. Even if not all urllib usage is replaced, I think getting rid of future.standard_library should resolve the problem reported in #1254 (e.g. seen here: http://tests.obspy.org/35446/)

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • +DOCS because some changes might affect the gallery
  • +TESTS:ALL
  • All tests still pass.

@megies megies added the PY2/3 label May 7, 2018

@megies megies added this to the 1.2.0 milestone May 7, 2018

@megies megies changed the title Use requests Remove some urllib and future.standard_library usages May 7, 2018

@krischer krischer added this to Free for the Taking in Release 1.2.0 Feb 14, 2019

megies added some commits Apr 15, 2016

@megies megies force-pushed the use_requests branch from 65ca646 to b71f3c8 Feb 14, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 14, 2019

Rebased on current master and force-pushed so that we have fresh CI results tomorrow.

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 15, 2019

Bump to 2.0.0

@megies megies modified the milestones: 1.2.0, 2.0.0 Feb 15, 2019

@megies megies removed this from Free for the Taking in Release 1.2.0 Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.