New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add read support for FOCMEC output files #2156
Conversation
Let us know once this is ready for review. |
Ready for review.. it's a bit ugly but this comes mostly from the But there's several test files that look really different and they all read OK. So that's good enough for me right now. Should people hit read errors we can still fix it later. |
Rebased |
so far only reads focal mechanisms with strike/dip/rake, no additional info or comments
individual focal mechanisms
header and adjust polarity count and misfit accordingly
Rebased on current master and force-pushed so that we have fresh CI results tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed tests on travis & appveyor seem unrelated
Just check whether your datetime stuff is still needed
Event, FocalMechanism, NodalPlanes, NodalPlane, Comment, CreationInfo) | ||
|
||
|
||
# XXX some current PR was doing similar, should be merged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this ? is this still valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think so, just a note for future reference I guess
|
||
|
||
# XXX some current PR was doing similar, should be merged to | ||
# XXX core/utcdatetime.py eventually.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
Test fails are unrelated. |
What does this PR do?
Add read support for focal mechanisms calculated using program FOCMEC (
out
andlst
files)PR Checklist
master
for new features,maintenance_...
for bug fixesCHANGELOG.txt
.