Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centos io.rg16 fix #2163

Merged
merged 1 commit into from May 30, 2018
Merged

centos io.rg16 fix #2163

merged 1 commit into from May 30, 2018

Conversation

d-chambers
Copy link
Member

This PR fixes the CentOS io.rg16 test fail found in this docker build.

@d-chambers d-chambers changed the title use native str for struct centos io.rg16 fix May 28, 2018
@megies megies added bug confirmed bug .io issues generally related to our read/write plugins labels May 29, 2018
@megies megies added this to the 1.1.1 milestone May 29, 2018
@megies
Copy link
Member

megies commented May 29, 2018

@d-chambers this should be based on maintenance branch. Can you rebase please? Or we just cherry-pick it if thats too much of a bother..

@d-chambers
Copy link
Member Author

I could, but I don't think 1.1.1 has the rg16 module. It won't land in a release until 1.2.0

@megies
Copy link
Member

megies commented May 30, 2018

I could, but I don't think 1.1.1 has the rg16 module. It won't land in a release until 1.2.0

Ah, good point! Nevermind my silly comment then.. ^^

@megies megies modified the milestones: 1.1.1, 1.2.0 May 30, 2018
Copy link
Member

@megies megies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@megies megies merged commit 06906f3 into master May 30, 2018
@megies megies deleted the centos_rg16_fix branch May 30, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug .io issues generally related to our read/write plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants