New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centos io.rg16 fix #2163

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
2 participants
@d-chambers
Member

d-chambers commented May 28, 2018

This PR fixes the CentOS io.rg16 test fail found in this docker build.

@d-chambers d-chambers changed the title from use native str for struct to centos io.rg16 fix May 28, 2018

@megies megies added bug .io labels May 29, 2018

@megies megies added this to the 1.1.1 milestone May 29, 2018

@megies

This comment has been minimized.

Member

megies commented May 29, 2018

@d-chambers this should be based on maintenance branch. Can you rebase please? Or we just cherry-pick it if thats too much of a bother..

@d-chambers

This comment has been minimized.

Member

d-chambers commented May 29, 2018

I could, but I don't think 1.1.1 has the rg16 module. It won't land in a release until 1.2.0

@megies

This comment has been minimized.

Member

megies commented May 30, 2018

I could, but I don't think 1.1.1 has the rg16 module. It won't land in a release until 1.2.0

Ah, good point! Nevermind my silly comment then.. ^^

@megies megies modified the milestones: 1.1.1, 1.2.0 May 30, 2018

@megies

megies approved these changes May 30, 2018

❤️

@megies megies merged commit 06906f3 into master May 30, 2018

7 of 8 checks passed

docker-deb-buildbot Deb packaging succeeded but tests failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 88.25% (+1.13%) compared to c2f9200
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-testbot Docker tests succeeded
Details

@megies megies deleted the centos_rg16_fix branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment