Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci builds (PPSD and others) #2424

Merged
merged 10 commits into from Jul 19, 2019

Conversation

@d-chambers
Copy link
Member

commented Jul 16, 2019

What does this PR do?

This PR attempts to get the travis CI working again.

Why was it initiated? Any relevant Issues?

Travis is failing

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
@d-chambers d-chambers changed the title fix_ci builds fix ci builds Jul 16, 2019
d-chambers added 2 commits Jul 16, 2019
@QuLogic

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Well, it's definitely looking better... We need to decide on something for the pickling thing to fix the last few bits (except the Python 2.7 build).

@d-chambers

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

It looks like py 2.7 the min dep. version is missing gfortran still, perhaps related to the issue you opened? I will try explicitly installing it on the min dep build.

@d-chambers

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Travis 2.7 build is still failing, any ideas on that one?

@QuLogic

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Hmm, I'm confused. Both pip freeze and conda list say NumPy is installed, so it should be... It must be failing to load some shared library dependency or something, but the message is not too clear. Try running a simple script that just import numpy and see what the real error is?

We should get out 1.2.0 and drop Python 2.7 support ASAP.

@megies
megies approved these changes Jul 19, 2019
Copy link
Member

left a comment

Thanks! Huge improvement, I'm merging this now, we can check out 2.7 later, I guess..

@megies megies merged commit 0c214da into master Jul 19, 2019
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
@megies megies deleted the fix_ci_2 branch Jul 19, 2019
@megies megies changed the title fix ci builds fix ci builds (PPSD and others) Sep 12, 2019
@d-chambers d-chambers referenced this pull request Sep 15, 2019
6 of 9 tasks complete
@megies megies added this to the 1.2.0 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.