Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UTCDateTime Regex for ordinal day 360 #2869

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

calum-chamberlain
Copy link
Contributor

What does this PR do?

Adapts the _ISO8601_REGEX to catch ordinal day 360.

Why was it initiated? Any relevant Issues?

This patch copes with issue #2868

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
    - [ ] First time contributors have added your name to CONTRIBUTORS.txt .

@calum-chamberlain calum-chamberlain added bug confirmed bug .core.utcdatetime issues related to our handling of time in UTCDateTime class labels Aug 17, 2021
@ThomasLecocq ThomasLecocq merged commit f254c2c into maintenance_1.2.x Jan 4, 2022
@ThomasLecocq
Copy link
Contributor

@d-chambers how do you cherry-pick maintenance items like this one back to master, as it's an important one ?

@ThomasLecocq
Copy link
Contributor

I cherry-picked in pycharm & pushed back to master (not sure it's the recommended way ...)

@QuLogic QuLogic deleted the utcdatetime-regex branch January 4, 2022 22:56
@QuLogic QuLogic added this to the 1.2.3 milestone Jan 4, 2022
@trichter trichter modified the milestones: 1.3.1, 1.3.0 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug .core.utcdatetime issues related to our handling of time in UTCDateTime class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants