-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ph5ws.resif.fr endpoint #2938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think testing is important for this one. Let's just check that CI succeeds (no reason to fail), then I'll merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want you can add a Changelog line, like this one
damn, conflict in the changelog :( |
You need to rebase and force-push :-) |
And don't forget to add yourself to |
Also change from https to http
I made a mess but I guess it's OK now. |
Don't worry. Let's see tests, than I'll squash-and-merge™ |
Good to merge? |
Nope, still one pending question. |
I missed the still pending question, sorry. What was it ? |
fun, I didn't see this one! |
Do you see it now? |
negative, when I go to the files it's not there - did you "submit your review" ? |
CHANGELOG.txt
Outdated
@@ -41,7 +41,7 @@ Changes: | |||
FDSN server URLs (#2878) | |||
* add URL mapping for IRISPH5, IESDMC, GEOFON (alternative to GFZ) | |||
(see #2739, #2932) | |||
* update RESIF URL mapping to use https | |||
* update RESIF URL mapping to use https and add RESIFPH5 (see #2938) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it seems to be the other way round: it used to be "https", now it is "http".
Could you check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I corrected the changelog, sorry about this :)
I guess that was the problem! |
Pending means you haven't posted it, not that it hasn't been answered. |
Merged! Thanks @jschaeff! |
What does this PR do?
Why was it initiated? Any relevant Issues?
I don't know if any testing is relevant for this PR.
It is a bit linked to issue #2914
PR Checklist
master
for new features,maintenance_...
for bug fixesJust remove the space in the following string after the + sign: "+ DOCS"
(e.g.
clients.fdsn,clients.arclink
) after the colon in the following magic string: "+TESTS:"(you can also add "ALL" to just simply run all tests across all modules)
CHANGELOG.txt
.CONTRIBUTORS.txt
.