fix more network tests #2980
fix more network tests #2980
Conversation
trichter
added
testing
trichter
force-pushed
the
network_tests
branch
from
624d534
to
51a7799
Compare
|
Looks like the non-network tests are failing due to new warnings cropping up. Perhaps not a big deal, should be easy to fix. |
|
Also, certainly not required but if you are feeling ambitious converting these test cases to pytest style is something we should do eventually. |
|
Looks like you are addressing the failures in #2978 |
I dont feel ambitious enough at the moment :) |
| @@ -234,14 +234,15 @@ def test_resp(self): | |||
| t2 = UTCDateTime("2008-001T00:00:00") | |||
| result = client.resp("IU", "ANMO", "00", "BHZ", t1, t2) | |||
| self.assertIn(b'B050F03 Station: ANMO', result) | |||
| # Exception: No response data available | |||
There was a problem hiding this comment.
Maybe choose a different response so that we can still test this part of the code?
There was a problem hiding this comment.
Still two requests left...
The site from which examples were taken still mentions this query. Maybe we can use this one.
|
@d-chambers Feel free to finish this one :) |
|
I implemented one more test in clients.iris module as suggested. I think this can be merged. |
trichter
removed
test_network
I fixed some more of the network tests. I skipped this one clients/iris doctest which I did not get to pass. The same thing is tested in the regular test suite.
This can be merged as is. Someone else needs to figure out those earthworm stuff. I have no clue about it.