Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove arclink client #2994

Merged
merged 1 commit into from Mar 4, 2022
Merged

remove arclink client #2994

merged 1 commit into from Mar 4, 2022

Conversation

megies
Copy link
Member

@megies megies commented Feb 28, 2022

What does this PR do?

Removes arclink client

Why was it initiated? Any relevant Issues?

It has been deprecated for years, officially discontinued and main
servers have been shut down years ago. no point dragging this along

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@trichter, feel free to bump to a later release

@megies megies added this to the 1.3.0 milestone Feb 28, 2022
@trichter
Copy link
Member

For me it's both OK, remove it now or right after the release of 1.3.0.

@d-chambers
Copy link
Member

Should we think about removing the other depreciated modules at the same time?

@megies
Copy link
Member Author

megies commented Mar 1, 2022

Should we think about removing the other depreciated modules at the same time?

which ones? but probably.. yes.. since its been a real long time since last release anyway

@d-chambers
Copy link
Member

which ones? but probably.. yes.. since its been a real long time since last release anyway

At least obspy.db and obspy.client.sieshub

@d-chambers d-chambers mentioned this pull request Mar 3, 2022
@megies
Copy link
Member Author

megies commented Mar 3, 2022

At least obspy.db and obspy.client.sieshub

I'd say yes, let's get rid of those two as well this release. I don't think these see much use anymore and we still have them in previous releases.

@megies
Copy link
Member Author

megies commented Mar 3, 2022

Hmm.. actually, I realized that they have not been marked deprecated in last release, only in master. So.. not sure

@megies
Copy link
Member Author

megies commented Mar 3, 2022

I'll push the remove commit anyway, since I was already done. Can still discuss and roll back that commit here

@d-chambers
Copy link
Member

I don't think it is a big deal since they probably aren't used much anyway, but I don't have a strong opinion.

@trichter
Copy link
Member

trichter commented Mar 4, 2022

It's also no big deal if they stay in the next release. Both options are good with me.

@megies
Copy link
Member Author

megies commented Mar 4, 2022

I got rid of the second commit (ff6a217) that removed db and clients.seishub, to stay in line with our policy of showing a deprecation message for at least one major release before removing stuff.

@megies
Copy link
Member Author

megies commented Mar 4, 2022

Rebased on current master

@megies
Copy link
Member Author

megies commented Mar 4, 2022

Good to go from my point of view

@megies megies added the ready for review PRs that are ready to be reviewed to get marked ready to merge label Mar 4, 2022
Copy link
Member

@trichter trichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, another line in pytest.ini can be removed.

@trichter
Copy link
Member

trichter commented Mar 4, 2022

I got rid of the second commit (ff6a217) that removed db and clients.seishub, to stay in line with our policy of showing a deprecation message for at least one major release before removing stuff.

You could move it to another branch. We can merge it after the release.

it has been deprecated for years, officially discontinued and main
servers have been shut down years ago. no point dragging this along
@megies megies merged commit 6ce06ad into master Mar 4, 2022
@megies megies deleted the remove_arclink_2 branch March 4, 2022 13:20
@trichter trichter removed the ready for review PRs that are ready to be reviewed to get marked ready to merge label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants