New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove arclink client #2994
remove arclink client #2994
Conversation
For me it's both OK, remove it now or right after the release of 1.3.0. |
Should we think about removing the other depreciated modules at the same time? |
which ones? but probably.. yes.. since its been a real long time since last release anyway |
At least obspy.db and obspy.client.sieshub |
I'd say yes, let's get rid of those two as well this release. I don't think these see much use anymore and we still have them in previous releases. |
Hmm.. actually, I realized that they have not been marked deprecated in last release, only in master. So.. not sure |
I'll push the remove commit anyway, since I was already done. Can still discuss and roll back that commit here |
I don't think it is a big deal since they probably aren't used much anyway, but I don't have a strong opinion. |
It's also no big deal if they stay in the next release. Both options are good with me. |
I got rid of the second commit (ff6a217) that removed |
Rebased on current master |
Good to go from my point of view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, another line in pytest.ini can be removed.
You could move it to another branch. We can merge it after the release. |
it has been deprecated for years, officially discontinued and main servers have been shut down years ago. no point dragging this along
What does this PR do?
Removes arclink client
Why was it initiated? Any relevant Issues?
It has been deprecated for years, officially discontinued and main
servers have been shut down years ago. no point dragging this along
PR Checklist
master
for new features,maintenance_...
for bug fixesJust add the "build_docs" tag to this PR.
clients.fdsn
) should be tested for the PR,just add the "test_network" tag to this PR.
CHANGELOG.txt
.CONTRIBUTORS.txt
.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.
@trichter, feel free to bump to a later release