Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated modules obspy.db and obspy.clients.seishub #3006

Merged
merged 1 commit into from Mar 17, 2022
Merged

remove deprecated modules obspy.db and obspy.clients.seishub #3006

merged 1 commit into from Mar 17, 2022

Conversation

megies
Copy link
Member

@megies megies commented Mar 4, 2022 •
edited

What does this PR do?

Removes deprecated modules db and clients.seishub

https://github.com/obspy/obspy/pull/3006/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7L140

Why was it initiated? Any relevant Issues?

Please fill in

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@megies megies added the cleanup code refactoring etc. label Mar 4, 2022
@megies megies added this to the 1.4.0 milestone Mar 4, 2022
barsch
barsch approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@barsch barsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally ;)

@megies
Copy link
Member Author

megies commented Mar 7, 2022

When merging, also should make a PR in conda-forge/obspy-feedstock, to remove entry points there as well

@megies megies marked this pull request as draft March 9, 2022 10:04
@trichter
Copy link
Member

I think this just needs a rebase and update of the changelog.

@megies megies marked this pull request as ready for review March 17, 2022 13:47
@megies megies mentioned this pull request Mar 17, 2022
Closed
@megies
Copy link
Member Author

megies commented Mar 17, 2022

should be good to merge after green CI now

@megies megies merged commit cffd127 into master Mar 17, 2022
@megies megies deleted the remove_db_seishub branch March 17, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsch barsch barsch approved these changes

Assignees
No one assigned
Labels
cleanup code refactoring etc.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megies @trichter @barsch