Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete read #3040

Merged
merged 2 commits into from Apr 8, 2022
Merged

Conversation

wasjabloch
Copy link
Contributor

What does this PR do?

Handle IncompleteRead exception by giving the user a hint on how to circumvent it.

Why was it initiated? Any relevant Issues?

fixes #3028

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@wasjabloch
Copy link
Contributor Author

Sorry, this should be merged into maintenance_1.3.x, which changed during refresh.

@wasjabloch
Copy link
Contributor Author

IncompleteRead does not have a message attribute, which is why we are raising HTTPException instead. The IncompleteRead will still show up in the traceback.

@trichter trichter changed the base branch from master to maintenance_1.3.x April 8, 2022 08:05
@megies megies added .clients.fdsn test_network tell github actions to also run network tests for this PR labels Apr 8, 2022
Copy link
Member

@megies megies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
I'll retrigger CI so we get FDSN tests run..

@megies
Copy link
Member

megies commented Apr 8, 2022

You could add a changelog one-liner, but it's a small change so I'm also OK with not having one.

@megies megies added this to the 1.3.1 milestone Apr 8, 2022
@megies
Copy link
Member

megies commented Apr 8, 2022

Thanks!

@megies megies merged commit cf8d1f0 into obspy:maintenance_1.3.x Apr 8, 2022
@megies
Copy link
Member

megies commented Apr 8, 2022

Added you to the devs team too, so you can push branches to main repo next time if you prefer that.

@wasjabloch wasjabloch deleted the fix_incomplete_read branch April 8, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.clients.fdsn test_network tell github actions to also run network tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http.client.IncompleteRead: IncompleteRead(145883 bytes read)
2 participants