try to fix CI problem

[megies]

What does this PR do?

Changes obspy installation in CI from editable to a regular pip installation.

Also remove the [tests] modifier, which does nothing in combination with --no-deps anyway and we rely on an environment file for all (testing) dependencies anyway.

Why was it initiated? Any relevant Issues?

Some test currently fails because files are being looked up in the install location, which is only holding a link to the source tree though, due to being a pip editable installation.

• https://github.com/obspy/obspy/actions/runs/3066925112/jobs/4952650308#step:10:268
• https://tests.obspy.org/127117/#1

• obspy/obspy/core/tests/test_waveform_plugins.py

  Lines 211 to 220 in 9d10a93

  	for f in formats:
  	path = os.path.join(f.dist.location,
  	*f.module_name.split('.')[:-1])
  	path = os.path.join(path, 'tests', 'data')
  	all_paths.append(path)
  	if os.path.exists(path):
  	paths[f.name] = path
  	msg = 'Test data directories do not exist:\n '
  	assert len(paths) > 0, msg + '\n '.join(all_paths)

PR Checklist

• Correct base branch selected? master for new features, maintenance_... for bug fixes
• This PR is not directly related to an existing issue (which has no PR yet).
• If the PR is making changes to documentation, docs pages can be built automatically.
  Just add the "build_docs" tag to this PR.
  Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
  Please post a link to the relevant piece of documentation.
• If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
  just add the "test_network" tag to this PR.
• All tests still pass.
• Any new features or fixed regressions are covered via new tests.
• Any new or changed features are fully documented.
• Significant changes have been added to CHANGELOG.txt .
• First time contributors have added your name to CONTRIBUTORS.txt .
• If the changes affect any plotting functions you have checked that the plots
  from all the CI builds look correct. Add the "upload_plots" tag so that plotting
  outputs are attached as artifacts.
• Add the "ready for review" tag when you are ready for the PR to be reviewed.

[megies]

@trichter not sure if there was a reason for doing an editable install in CI, but it started to cause issues and it looks like a regular install does just fine..

[trichter]

I think for no specific reason.

[trichter]

What I do not understand is, why this error appeared all of a sudden in the CI setup. I myself use this setup for my obspy installation. Will report when/if it breaks.

[megies]

I use editable installs all the time too, locally. But CI can have some special setups makin it weird, looks like auto stripping of test file directries maybe? Who knows..

[megies]

I actually can reproduce the problem locally now.. happens when using a pip editable install and then going via obspy-runtests.

[trichter]

For my local installation it is still working. Maybe a change in the entry points stuff of setuptools. Should we revert this PR?

[megies]

For my local installation it is still working. Maybe a change in the entry points stuff of setuptools. Should we revert this PR?

The underlying problem was fixed by #3175. On a fresh installation with all the newest packages and installing obspy editable after reverting that commit, it fails. As you say, seems to be a change in setuptools, reporting the shimmy directory instead of the git repository location as install base dir.

Anyway, I dont care, if you want to revert this go ahead.

EDIT: Ah wait, I thought you meant reverting the CI script to be an editable install again. We can not revert this PR, like stated, obspy-runtests on an editable install still fails if you revert this

[megies]

to reproduce:

conda create -n trash obspy
conda activate trash
conda remove --force --offline obspy
pip install -e /path/to/obspy
# manually revert this commit
obspy-runtests

[megies]

Oh boy.. too many swapping around tabs and issues.. @trichter yes this change in CI script can be changed back to editable install if you want

[trichter]

It's OK. I don't care enough.