Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radius in kilometers2degrees and degrees2kilometers can be float type #3179

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 17, 2022

What does this PR do?

Update the documentation to indicate the radius in kilometers2degrees and degrees2kilometers can be float type.

Why was it initiated? Any relevant Issues?

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@seisman seisman added the ready for review PRs that are ready to be reviewed to get marked ready to merge label Oct 17, 2022
@megies megies changed the base branch from maintenance_1.3.x to master October 17, 2022 14:49
@megies megies merged commit 7598e33 into master Oct 17, 2022
@megies megies deleted the kilometers2degrees-float branch October 17, 2022 14:50
@QuLogic QuLogic added this to the 1.4.0 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PRs that are ready to be reviewed to get marked ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants