Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdsn: change NCEDC base URL to https #3203

Merged
merged 2 commits into from Nov 3, 2022
Merged

fdsn: change NCEDC base URL to https #3203

merged 2 commits into from Nov 3, 2022

Conversation

megies
Copy link
Member

@megies megies commented Nov 3, 2022

What does this PR do?

change FDSNWS URL for NCEDC to https

Why was it initiated? Any relevant Issues?

fixes #3201

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@megies megies added this to the 1.4.0 milestone Nov 3, 2022
@megies megies merged commit ec7b76b into master Nov 3, 2022
@megies megies deleted the ncedc_https branch November 3, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCDEC fdsn goes HTTPS
1 participant