Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map plots with custom user options #3217

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

megies
Copy link
Member

@megies megies commented Nov 15, 2022

What does this PR do?

Fixes map plots with user specified options like custom "projection" kwarg. These weren't properly passed through to the new helper method for initial cartopy plot setup, so default values were always winning.

Why was it initiated? Any relevant Issues?

fixes #3191

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the ready for review tag when you are ready for the PR to be reviewed.

kwargs like "projection" weren't properly passed through to the initial
plot setup
@megies megies added .core issues affecting our functionality at the very core .imaging Issues with our plotting functionalities ready for review PRs that are ready to be reviewed to get marked ready to merge labels Nov 15, 2022
@megies megies added this to the 1.4.0 milestone Nov 15, 2022
@megies megies added the build_docs Docs will be automatically built and deployed in github actions on pushes to the PR label Nov 15, 2022
@megies
Copy link
Member Author

megies commented Nov 15, 2022

@megies megies merged commit 0d77efd into master Nov 15, 2022
@megies megies deleted the fix_map_plot_initial_setup branch November 15, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_docs Docs will be automatically built and deployed in github actions on pushes to the PR .core issues affecting our functionality at the very core .imaging Issues with our plotting functionalities ready for review PRs that are ready to be reviewed to get marked ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory projection "local" plot broken
1 participant