Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more NRL client changes for NRLv2 #3315

Merged
merged 8 commits into from Jul 7, 2023
Merged

more NRL client changes for NRLv2 #3315

merged 8 commits into from Jul 7, 2023

Conversation

megies
Copy link
Member

@megies megies commented Jun 22, 2023 •
edited

What does this PR do?

Make some more adjustments to NRL client due to server side change to new NRL version 2.

Why was it initiated? Any relevant Issues?

Fixes #3122

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies
Revert "NRL v2: ignore duplicated sections for now (REVERT LATER)"
ddfc5c4 
This reverts commit 8dcb9ab.
I just checked with a full download of NRLv2 in RESP format and that bug
they had seems fixed.
@megies
NRL: fix units in response chain for NRL v2
3891ee3 
we needed a little workaround to fix most datalogger-only responses
starting with a gain-only response stage without units.
see long comment in source code in this commit
@megies
nrl: refactoring, reduce code duplication
5c460e3
@megies
nrl: show some warnings when users request datalogger-only response
d4628e7 
since most of these requests will return responses that have bad units
on overall sensitivity and first stage because of how NRL v2 has most
first stages of dataloggers as gain-only stages without units set
@megies
nrl: add tests for NRL v2 offline use
f95f464
@megies megies added this to the 1.4.1 milestone Jun 22, 2023
@megies megies self-assigned this Jun 22, 2023
@megies megies merged commit 24273f7 into maintenance_1.4.x Jul 7, 2023
24 of 25 checks passed
@megies megies deleted the nrl_stuff branch July 7, 2023 14:16
@megies megies mentioned this pull request Jan 24, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@megies megies

Labels
clients.nrl
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@megies