fix a minor issue with a matplotlib API change with 3.6 in interactive plot #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megies
added
the
ready for review
filefolder
approved these changes
Jul 7, 2023
QuLogic
reviewed
Jul 21, 2023
Comment on lines
+1458
to
+1461
| if MATPLOTLIB_VERSION < [3, 6]: | ||
| ax.texts.remove(self._minmax_warning_text) | ||
| else: | ||
| self._minmax_warning_text.remove() |
There was a problem hiding this comment.
Text.remove has always existed; there's no need to version-gate this.
There was a problem hiding this comment.
Thanks! Will remove the if/else tomorrow 🚀
megies
added a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a minor issue due to an API change in recent matplotlib 3.6. The warning message we show in interactive plot windows for Min-Max plots that make no sense when zooming in to much couldn't be removed as intended anymore when zooming back out.
Why was it initiated? Any relevant Issues?
Fixes #3318
PR Checklist
masterfor new features,maintenance_...for bug fixesno_cilabel can be added to skip CI buildsJust add the
build_docstag to this PR.Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
clients.fdsn) should be tested for the PR,just add the
test_networktag to this PR.CHANGELOG.txt.CONTRIBUTORS.txt.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.
CODEOWNERSwith your github handleready for reviewlabel when you are ready for the PR to be reviewed.