Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to scipy changes, window functions have moved #3329

Merged
merged 1 commit into from Jul 24, 2023

Conversation

megies
Copy link
Member

@megies megies commented Jul 24, 2023

What does this PR do?

Fix some scipy imports of windowing functions that have been moved around in scipy.

Why was it initiated? Any relevant Issues?

Fixes #3326

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies megies added this to the 1.4.1 milestone Jul 24, 2023
also, slepian had been deprecated in scipy 1.1.0 and was removed in
1.6.0 so we need to do something about it in next obspy major release
@megies megies merged commit 08d6790 into maintenance_1.4.x Jul 24, 2023
15 of 25 checks passed
@megies megies deleted the fix_scipy_window_imports branch July 24, 2023 13:40
megies added a commit that referenced this pull request Oct 27, 2023
@liamtoney liamtoney mentioned this pull request Apr 5, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant