Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flake8 E721 #3344

Merged
merged 2 commits into from Aug 29, 2023
Merged

fix flake8 E721 #3344

merged 2 commits into from Aug 29, 2023

Conversation

megies
Copy link
Member

@megies megies commented Aug 29, 2023 •
edited

What does this PR do?

Fix new flake8 fails: E721

Why was it initiated? Any relevant Issues?

Code linter fails on main branches

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies megies added the cleanup code refactoring etc. label Aug 29, 2023
@megies megies added this to the 1.4.1 milestone Aug 29, 2023
@megies megies added the ready for review PRs that are ready to be reviewed to get marked ready to merge label Aug 29, 2023
@filefolder filefolder self-assigned this Aug 29, 2023
@megies
correct previous flake8 corrections in two cases
3b39129 
two cases where only matching a specific class and *not* matching their
subclasses is intended in io.stationxml
@megies
Copy link
Member Author

megies commented Aug 29, 2023

All green should be good

@megies megies merged commit ff65335 into maintenance_1.4.x Aug 29, 2023
25 checks passed
@megies megies deleted the fix_flake8 branch August 29, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trichter trichter Awaiting requested review from trichter trichter is a code owner

@d-chambers d-chambers Awaiting requested review from d-chambers d-chambers is a code owner

Assignees

@filefolder filefolder

Labels
cleanup code refactoring etc. ready for review PRs that are ready to be reviewed to get marked ready to merge
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@megies @filefolder