Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpl backend switcher: close figures explicitly #3362

Merged
merged 1 commit into from Oct 26, 2023

Conversation

megies
Copy link
Member

@megies megies commented Oct 26, 2023

What does this PR do?

Close all figures in a helper context manager that temporarily switches mpl backend.

Why was it initiated? Any relevant Issues?

matplotlib is showing deprecation warnings that this was done in mpl automatically but will not be done anymore in the future, so we have to do it, see e.g. https://tests.obspy.org/135767/#1

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

matplotlib is showing deprecation warnings that this was done in mpl
automatically but will not be done anymore in the future, so we have to
do it, see e.g. https://tests.obspy.org/135767/#1
@megies megies added this to the 1.4.1 milestone Oct 26, 2023
@megies megies added the ready for review PRs that are ready to be reviewed to get marked ready to merge label Oct 26, 2023
@megies megies merged commit 4349f13 into maintenance_1.4.x Oct 26, 2023
26 checks passed
@megies megies deleted the fix_mpl_warning_figure_closing branch October 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PRs that are ready to be reviewed to get marked ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant