Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress a DeprecationWarning in a dependency #3364

Merged
merged 1 commit into from Oct 26, 2023
Merged

suppress a DeprecationWarning in a dependency #3364

merged 1 commit into from Oct 26, 2023

Conversation

megies
Copy link
Member

@megies megies commented Oct 26, 2023 •
edited

What does this PR do?

Suppress a new deprecation warning on Python 3.12 in dateutil.

Why was it initiated? Any relevant Issues?

This warning pops up before our pytest.ini takes effect, so it isn't ignored by our pytest rules and immediately fails on pytest -W error which we use in one of our CI test runners, causing overall CI fail.
This was fixed in dateutil 4 months ahead of Python 3.12 final release with dateutil/dateutil#1285, but looks like dateutil hasn't seen any releases since 2021..

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies
suppress a DeprecationWarning that happens before our pytest.ini goes…
2bf170b 
… into effect

which means this otherwise fails our CI test runner that checks for
uncaught warning messages
@megies megies added testing issues generally related to our testing setup / infrastructure cleanup code refactoring etc. labels Oct 26, 2023
@megies megies added this to the 1.4.1 milestone Oct 26, 2023
@megies megies merged commit 2f8b4c5 into maintenance_1.4.x Oct 26, 2023
25 checks passed
@megies megies deleted the fix_dateutil_deprecation branch October 26, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trichter trichter Awaiting requested review from trichter trichter is a code owner

@d-chambers d-chambers Awaiting requested review from d-chambers d-chambers is a code owner

Assignees
No one assigned
Labels
cleanup code refactoring etc. testing issues generally related to our testing setup / infrastructure
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@megies