New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tsindex feb2024 #3403
base: master
Are you sure you want to change the base?
Fix tsindex feb2024 #3403
Conversation
@chad-earthscope I think this is mixing changes that can go into
.. with a change that should go into
Can we split this up? (I changed the merge target branch to see what is actually going on in here) |
sa.case((sa.literal(f) == '*', | ||
sa.literal('5000-00-00T00:00:00')), | ||
else_=sa.literal(f) | ||
).label("endtime") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is different on the maintenance_1.4.x
branch, so not sure what needs to be done exactly if it should go into 1.4.1
sa.case((sa.literal(f) == '*', | ||
sa.literal('5000-00-00T00:00:00')), | ||
else_=sa.literal(f) | ||
).label("endtime") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here..
Besides these two parts above, the rest could be cherry-picked cleanly on top of a branch off of |
What does this PR do?
Changses to the obspy.clients.filesystem.tsindex module:
Why was it initiated? Any relevant Issues?
SQLAlchemy failures during testing and new mseedindex program that handles multiple versions of miniSEED.
Note: the mseedindex package in PyPI is now up to date with the current release: https://pypi.org/project/mseedindex/ and likely how ObsPy users will get this program.
PR Checklist
master
for new features,maintenance_...
for bug fixesno_ci
label can be added to skip CI buildsJust add the
build_docs
tag to this PR.Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
clients.fdsn
) should be tested for the PR,just add the
test_network
tag to this PR.CHANGELOG.txt
.CONTRIBUTORS.txt
.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.
CODEOWNERS
with your github handleready for review
label when you are ready for the PR to be reviewed.