Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESP: Fix reading Poles/zeros uncertainties #3412

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

megies
Copy link
Member

@megies megies commented Feb 29, 2024

What does this PR do?

Fix properly interpreting poles/zeros complex uncertainties stored in RESP files (already done correctly reading StationXML files)

Why was it initiated? Any relevant Issues?

Fixes #3401

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies megies added bug confirmed bug .io.xseed labels Feb 29, 2024
@megies megies added this to the 1.4.1 milestone Feb 29, 2024
@megies megies added the ready for review PRs that are ready to be reviewed to get marked ready to merge label Feb 29, 2024
@megies megies changed the title add regression test for #3401 RESP: Fix reading Poles/zeros uncertainties Mar 4, 2024
@megies megies merged commit 71cc344 into maintenance_1.4.x Apr 12, 2024
26 checks passed
@megies megies deleted the fix_resp_complex_uncertainties branch April 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug .io.xseed ready for review PRs that are ready to be reviewed to get marked ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant