Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdsn: update links for ISC and LMU #3413

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fdsn: update links for ISC and LMU #3413

merged 2 commits into from
Mar 4, 2024

Conversation

megies
Copy link
Member

@megies megies commented Feb 29, 2024 •
edited
Loading

What does this PR do?

Updates links to FDSN servers at ISC and LMU

Why was it initiated? Any relevant Issues?

fixes #3388

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies megies added this to the 1.4.1 milestone Feb 29, 2024
@megies megies added ready for review PRs that are ready to be reviewed to get marked ready to merge test_network tell github actions to also run network tests for this PR labels Feb 29, 2024
filefolder
filefolder reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@filefolder filefolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the two new ones, works fine

the raspberry shake server seems to be down however. the address is also different from the one registered at http://www.fdsn.org/datacenters/detail/RASPISHAKE/

probably wait until can confirm which one it's supposed to be / which is working?

@megies
Copy link
Member Author

megies commented Mar 4, 2024

the raspberry shake server seems to be down however. the address is also different from the one registered at http://www.fdsn.org/datacenters/detail/RASPISHAKE/

probably wait until can confirm which one it's supposed to be / which is working?

Raspberryshake is unrelated, we can fix it whenever there is something to do with it =)

@megies megies merged commit 9ef5860 into maintenance_1.4.x Mar 4, 2024
27 checks passed
@megies megies deleted the fdsn_isc_link branch March 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filefolder filefolder filefolder left review comments

Assignees
No one assigned
Labels
.clients.fdsn ready for review PRs that are ready to be reviewed to get marked ready to merge test_network tell github actions to also run network tests for this PR
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@megies @filefolder