Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to a function name change in scipy #3437

Merged
merged 1 commit into from Apr 30, 2024
Merged

Conversation

megies
Copy link
Member

@megies megies commented Apr 30, 2024

What does this PR do?

Adjust a scipy import to a function name change

Why was it initiated? Any relevant Issues?

Shows deprecation warning in tests and will break with next scipy major version

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

shows a deprecation and will break in next scipy release
@megies megies added .signal issues related to our signal processing functionalities cleanup code refactoring etc. labels Apr 30, 2024
@megies megies added this to the 1.4.1 milestone Apr 30, 2024
@megies megies merged commit a74d6b5 into maintenance_1.4.x Apr 30, 2024
25 checks passed
@megies megies deleted the deprecations branch April 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code refactoring etc. .signal issues related to our signal processing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant