Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seedlink: fix a bug in basic client get_info() #3445

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

megies
Copy link
Member

@megies megies commented May 14, 2024

What does this PR do?

Handles a bug in seedlink basic client get_info(), first reported in #2808

Channels for stations without data made it into the info results and caused an exception due to fnmatch chocking on None values. No-data stations will now be removed from results and a warning is shown indicating what stations were removed (with a kwarg option to suppress the warning)

Why was it initiated? Any relevant Issues?

closes #2808

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies megies added .clients.seedlink test_network tell github actions to also run network tests for this PR build_docs Docs will be automatically built and deployed in github actions on pushes to the PR labels May 14, 2024
@megies megies added this to the 1.5.0 milestone May 14, 2024
@megies
Copy link
Member Author

megies commented May 15, 2024

Failures unrelated

@megies megies merged commit 635af4e into master May 15, 2024
30 of 35 checks passed
@megies megies deleted the seedlink_basic_info branch May 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_docs Docs will be automatically built and deployed in github actions on pushes to the PR .clients.seedlink test_network tell github actions to also run network tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants