Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace.taper(): Remove 'slepian', add 'dpss' window #3449

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

megies
Copy link
Member

@megies megies commented May 16, 2024

What does this PR do?

Removes 'slepian' from Trace.taper() scipy plugins points as it was removed in scipy 1.6 and add 'dpss' as replacement. Don't know how to exactly mimic old slepian with new dpss function so can't prevent user code breaking, though, but at least a replacement is in place for people that used it.

Why was it initiated? Any relevant Issues?

fixes #3331

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

there is a replacement function 'dpss' but not sure how to exactly mimic
the old behavior
@megies megies added .core issues affecting our functionality at the very core .signal issues related to our signal processing functionalities labels May 16, 2024
@megies megies added this to the 1.5.0 milestone May 16, 2024
@megies megies changed the title Remove slepian Trace.taper(): Remove 'slepian', add 'dpss' window May 16, 2024
@megies megies added the ready for review PRs that are ready to be reviewed to get marked ready to merge label May 16, 2024
@megies megies merged commit 4f3bb19 into master May 17, 2024
30 checks passed
@megies megies deleted the remove_slepian branch May 17, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.core issues affecting our functionality at the very core ready for review PRs that are ready to be reviewed to get marked ready to merge .signal issues related to our signal processing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle "slepian" window that was removed in scipy
2 participants