-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dayplot error when giving the events argument #767
Conversation
st = read("http://examples.obspy.org/GR.BFO..LHZ.2012.108")
st.plot(type = 'dayplot', events=[{"time": UTCDateTime("2014-03-29T04:09:42"), "text": "M 5.1"}]) works for me as expected on master - in order to fix this I need more details - e.g. python version, obspy version, input data |
Your example actually fails with a different error on master now (maybe Py 3 problem?):
|
I've added two tests for day plots; one plain, one with an event. I've also fixed the bug indicated by the reporter. However, the error I found above is not fixed yet, since it doesn't seem to be triggered by the example I used. This will probably fail due to a bug in python-future (PythonCharmers/python-future#76). There are also some warnings due to a bug in matplotlib (matplotlib/matplotlib#3271). |
event.picks only exists if event is downloaded from neries. If event is just a dictionary of time/text, then it shouldn't be accessed.
These don't currently work. The events are placed on the wrong line.
Also broken for same reasons as previous commit.
One more test for plotting events with a catalog. |
I'll merge this as soon as future 0.12.4 is released. Otherwise we would have a constantly failing build... |
Dayplot error when giving the events argument
I am giving the events argument to generate the dayplot with events labeled on the plot, but it gave me the following error, looking into the waveform.py, it seems this check should be checked when the code automatically download the Catalog object (when using events={"min_magnitude": 5.5}) instead of manually giving the time of the events.