Make sure old imports still work #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just appears to be necessary...
Appears to work on Python 3.4.
Otherwise it somehow messes with builtins on Python 2.7.
ascii() is a built-in function on Python 2.7. Thus one would need to use __getattribute__ in attribute remapping helper class requiring a bunch more logic. This is really not worth it here as very few people would have directly imported obspy.core.ascii in the first place.
|
This fixes some issues with #842 and also makes "attribute access imports" like import obspy
obspy.xseed.Parser(filename)work. These worked before and I fear they are fairly common so we have to provide a deprecation path. |
|
Only Python 2.6 CI fails which is expected and fixed in #996 |
krischer
added a commit
that referenced
this pull request
Mar 24, 2015
Make sure old imports still work
|
@krischer |
|
Good point. I'll add a deprecation path. |
|
Done in #999. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a continuation of #842 as it makes sure that packages relying on imports in ObsPy 0.10 still work with the latest master where we reorganized the structure.
With this PR, none of my codes relying on ObsPy require any changes and warnings are raised appropriately.
All of this can be removed as soon as 0.11 has been released.