Add Prism metric #79
Merged
Add Prism metric #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # setup.py
- Test cases updated.
- Pytest configuration timeout increased.
- Prism model identifier added as a property.
…chitectures. - Typos corrected.
- Removed untar helper from utils as DLManager can also extract the downloaded file (zip or tar).
…anager, specifically for large downloads (e.g. Prism model)).
Sophylax
suggested changes
Feb 18, 2022
Sophylax
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75.
NOTE: Currently there is no device option for the original implementation of prism. The current implementations uses CUDA if available, and if not available it only then falls back to CPU. This is a problematic issue since VRAM might not be fit for a specified/default model, and there are many potential occasions user's would want to run the scoring model on CPU. Hence, This current commit is a CI trial of tests (currently failing locally due to this issue).