Update Transformers and AllenNLP Requirements #56
Conversation
|
Turns out the black requirement in dev also needs to be updated. (There is a bug with click being updated, it was either that or fix click version.) I believe adding that to this PR is still in scope (which is updating requirements). |
requirements.txt
Outdated
| @@ -1,8 +1,8 @@ | |||
| allennlp>=2.3.0,<=2.9.0.dev20211215 | |||
| allennlp==2.10.0 | |||
There was a problem hiding this comment.
Can't we relax this to >= ?
There was a problem hiding this comment.
Just allennlp>=2.10.0 feels too open. Maybe with <2.11 as well?
There was a problem hiding this comment.
Good idea, also it is the common practice.
| @@ -1,8 +1,8 @@ | |||
| allennlp>=2.3.0,<=2.9.0.dev20211215 | |||
| allennlp==2.10.0 | |||
| datasets>=1.13.0,<2.0 | |||
| deepdiff>=5.2.0 | |||
| jury>=2.1.0,<3.0 | |||
| numpy>=1.21.2 | |||
| seqeval==1.2.2 | |||
There was a problem hiding this comment.
Not related to your changes but I wonder if we can support >= in seqeval and tensorboardX as well?
There was a problem hiding this comment.
I can check it if you want, but it might take some time. Maybe we can make it an issue and look at it separately?
There was a problem hiding this comment.
Yes, it would be good as a remainder too even if we do not find time for that now.
With Transformers 4.18, we can use the new versions of transformers. There was a range of versions before that had a typing error which caused errors.
The earliest version of AllenNLP that supports 4.18 is 2.9.3. Which then had a bug with cached-path being updated and breaking some of the things on their side. 2.10.0, therefore, is the earliest version we can support with the new transformer requirement (and currently is the latest version).