Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Transformers and AllenNLP Requirements #56

Merged
merged 4 commits into from Aug 2, 2022
Merged

Update Transformers and AllenNLP Requirements #56

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75b65c5
Update AllenNLP and Transformers Requirements
Sophylax Jul 27, 2022
6aee16f
Relax Transformer Requirement to 4.18
Sophylax Jul 28, 2022
5ae208a
Update 'black' Version in 'dev' Requirements
Sophylax Jul 28, 2022
153b774
Relax AllenNLP Requirement
Sophylax Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
@@ -1,8 +1,8 @@
allennlp>=2.3.0,<=2.9.0.dev20211215
allennlp==2.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we relax this to >= ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just allennlp>=2.10.0 feels too open. Maybe with <2.11 as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, also it is the common practice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

datasets>=1.13.0,<2.0
deepdiff>=5.2.0
jury>=2.1.0,<3.0
numpy>=1.21.2
seqeval==1.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your changes but I wonder if we can support >= in seqeval and tensorboardX as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can check it if you want, but it might take some time. Maybe we can make it an issue and look at it separately?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be good as a remainder too even if we do not find time for that now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57 is created.

tensorboardX==2.1
transformers>=4.11.0,<4.16
transformers>=4.18,<4.21
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ def get_requirements():

extras_require = {
"dev": [
"black==21.7b0",
"black==22.3.0",
"flake8==3.9.2",
"isort==5.9.2",
"pytest>=6.2.4",
Expand Down