refactor: fix plugin export #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjose
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Nice work, @SihamBen 🙌! Just a few enhancements to clean up the implementation:
- Add
app.plugin.jsto.gitignore - Clean up dependencies by removing unused deps, as well as scripts
- Add prettier format script
"format": "prettier --write \"**/*.{ts,md,json}\" --ignore-path .gitignore", - For the build script, you need to copy the typing to the root file too if you need it. If not, then no need to generate it; in this case, remove the
--dtsflag while buildingapp.plugin.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the problem with having to export Plugin from
app-icon-badge/dist/js.Reaching inside a package is considered bad form based on expo docs.
We need to be able to import our plugin from root folder, or the alternative is having app.plugin.js file in root.
Fix was to rename plugin file to app.plugin.ts and copy file to root on build