Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial balance as suggested by @luc-demeyer #2

Open
wants to merge 1 commit into
base: push-here
Choose a base branch
from
Open

initial balance as suggested by @luc-demeyer #2

wants to merge 1 commit into from

Conversation

lepistone
Copy link

ping @damdam-s

@lepistone
Copy link
Author

👎 I think there is a problem here: this is an sql view that is created in advance. At this point we do not know fy_date yet. Where is it supposed to come from? The wizard? The filtering should probably be done after the fact, maybe with an odoo filter. (cc @simahawk too)

@damdam-s
Copy link

this PR needs #3 to work. In fact fy_date field will be computed according to the date_range selected on the wizard. Maybe we need to add this date_range_id field in wizard for general/partner ledger before all. cc @lepistone @simahawk

JordiBForgeFlow pushed a commit to ForgeFlow/account-financial-reporting that referenced this pull request Nov 23, 2017
@lepistone @JordiBForgeFlow
bring back in inner filter in year start
9a9e166 
It is @luc-demeyer and @jbeficient that proposed this approach: in inner
WHERE clause on the start of the fiscal year makes sure that initial and
running balances are correct. This means that depending of the account
type, totals are computed from the start of the fiscal year or from the
beginning of time. This was initially suggested in

oca-sorrento#2

The WHERE clause on date_from and date_to is different and it is
outside because it affects which line are shown but not the initial and
running balance.
pedrobaeza pushed a commit to ForgeFlow/account-financial-reporting that referenced this pull request Dec 5, 2017
@lepistone @pedrobaeza
bring back in inner filter in year start
60070bb 
It is @luc-demeyer and @jbeficient that proposed this approach: in inner
WHERE clause on the start of the fiscal year makes sure that initial and
running balances are correct. This means that depending of the account
type, totals are computed from the start of the fiscal year or from the
beginning of time. This was initially suggested in

oca-sorrento#2

The WHERE clause on date_from and date_to is different and it is
outside because it affects which line are shown but not the initial and
running balance.
i-vyshnevska pushed a commit to i-vyshnevska/account-financial-reporting that referenced this pull request May 12, 2019
@lepistone
bring back in inner filter in year start
183c71d 
It is @luc-demeyer and @jbeficient that proposed this approach: in inner
WHERE clause on the start of the fiscal year makes sure that initial and
running balances are correct. This means that depending of the account
type, totals are computed from the start of the fiscal year or from the
beginning of time. This was initially suggested in

oca-sorrento#2

The WHERE clause on date_from and date_to is different and it is
outside because it affects which line are shown but not the initial and
running balance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lepistone @damdam-s