Incorrect icons

[sbidoul]

Example here: https://odoo-community.org/shop/product/mis-builder-1636?search=mis+builder

The acsone icon should not be there. It is not obvious where it comes from, as it is used nowhere in that module in github.

[elicoidal]

It is probably due to the fact that the algorithm will try to explore any kind of image in the module to display in front and pick the one of the contributor/maintainer in case of absence (a guess as I didnot revisit the code).

We should probably discuss the basic selection rules for images (in order of priority):

1. image tag in manifest
2. icon in description folder
3. standard OCA icon

cc @OCA/board

[pedrobaeza]

The module icon should have priority for sure.

[elicoidal]

I am not sure here.
I would like to achieve this:

and icons are not suitable by default for this: an image with proper design is better

[pedrobaeza]

Well, that's not what is achieved right now any way.

[elicoidal]

I know: we are still finetuning 😉

[bizzappdev]

it is taking the priority from https://github.com/OCA/interface-github/blob/11.0/github_connector_odoo/models/odoo_module_version.py#L23
as static/src/img path is first it is taking the icon from that path.
https://github.com/OCA/mis-builder/blob/8.0/mis_builder/static/src/img/icon.png

[pedrobaeza]

Agh, curious thing! It's taking an old icon (valid for <v8) that hasn't been removed through all versions. @sbidoul can you please remove it in all branches? Or should I?

[elicoidal]

@sbidoul @pedrobaeza Is this taken care of? Is there anything we could help?

[elicoidal]

@bizzappdev What do you think about the image management?
Today we have another open issue #28 where the image is not even and I think we can improve without much work.
Shall I start a specific issue for that?

[pedrobaeza]

In this case, @sbidoul should remove that old icon in the repo.

[sbidoul]

Sorry guys, I lost the thread. What should I do exactly?

[pedrobaeza]

Remove the acsone icon in mis-builder in the offending route (static/src/img/icon.png).

[sbidoul]

At least the link above shows a 404 since many weeks. Is there another one?

[bizzappdev]

yes as it has been already taken care OCA/mis-builder@9b8f701
and also proper Image is on app store.
https://odoo-community.org/shop/product/mis-builder-1636?search=mis+builder

[pedrobaeza]

Ok, then this should be correct and can be closed.